Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction/pool endpoint issues #6651

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Fix transaction/pool endpoint issues #6651

merged 2 commits into from
Dec 6, 2024
+22 −4

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

  • if hash is not explicitly provided, it is not returned in response
  • when requesting with fields=*, senderShard and receiverShard are always 0

Proposed changes

  • fix the fields

Testing procedure

  • standard system test + add some cross shard txs in the pool. Check:
    • /transaction/pool?fields=* returns proper shards for sender and receiver.
    • /transaction/pool?by-sender="sender"&fields="*" returns proper shards
    • /transaction/pool?by-sender="sender"&fields=sender returns txHash as well(same for all combinations of fields)

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Dec 5, 2024
@multiversx multiversx deleted a comment from github-actions bot Dec 5, 2024
@sstanculeanu
Copy link
Collaborator Author

Run Tests:
mx-chain-testing-suite: main
mx-chain-simulator-go: main

sasurobert
sasurobert previously approved these changes Dec 5, 2024
View reviewed changes
miiu96
miiu96 previously approved these changes Dec 5, 2024
View reviewed changes
bogdan-rosianu
bogdan-rosianu previously approved these changes Dec 5, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 4c24359ab89654bee5b184d2506d31cd959165bf
  • Current Branch: master
  • mx-chain-go Target Branch: ``
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-101352
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: d744ac4e4f139f7c588777cf796ce5c263092ab7
  • Current Branch: mx-16113_fix_transaction_pool_endpoint
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-101519
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 9ac1370cac952b953b920d5da4b71d7009bd9636
  • Current Branch: mx-16113_fix_transaction_pool_endpoint
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-102156
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rc/spica-patch-relayedv3@5656a3e). Learn more about missing BASE report.

Additional details and impacted files 
@@                     Coverage Diff                     @@
##             rc/spica-patch-relayedv3    #6651   +/-   ##
===========================================================
  Coverage                            ?   78.69%           
===========================================================
  Files                               ?      753           
  Lines                               ?    99299           
  Branches                            ?        0           
===========================================================
  Hits                                ?    78143           
  Misses                              ?    15885           
  Partials                            ?     5271

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elvisboghiu
elvisboghiu approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@elvisboghiu elvisboghiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test:
Normal allin test: v1.8.4-dev-config-171a31edab -> mx-16113_fix_transaction_p-9ac1370cac
--- Specific errors ---
block hash does not match 1924
wrong nonce in block 762
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 280
Nr. of new ERRORS: 0
Nr. of new WARNS: 38
Nr. of PANICS: 0
Nodes with panic: []
/------/
--- System test go ---
All scenarios from system-test-go are OK!
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
ovh-p03-validator-28 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 5
ovh-p03-validator-10 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-18 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-16 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-34 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-35 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-21 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-32 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
ovh-p03-validator-11 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
ovh-p03-validator-1 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-31 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-26 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
ovh-p03-validator-30 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-15 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
ovh-p03-validator-20 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-8 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-2 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
/------/

@sstanculeanu sstanculeanu merged commit 73c8af3 into rc/spica-patch-relayedv3 Dec 6, 2024
10 checks passed
@sstanculeanu sstanculeanu deleted the mx-16113_fix_transaction_pool_endpoint branch December 6, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

@miiu96 miiu96 miiu96 approved these changes

@elvisboghiu elvisboghiu elvisboghiu approved these changes

@sasurobert sasurobert sasurobert approved these changes

Assignees

@sstanculeanu sstanculeanu

Labels
area:node-api Node API complexity:trivial impact:low interested:api-multiversx-com interested:protocol type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sstanculeanu @sasurobert @elvisboghiu @miiu96 @bogdan-rosianu